QuerySets: check for .is_superuser instead of has_perm #8181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +16,7 @@ class ProjectQuerySetBase(models.QuerySet): | |||
| use_for_related_fields = True | |||
|
|
|||
| def _add_user_repos(self, queryset, user): | |||
| if user.has_perm('projects.view_project'): | |||
There was a problem hiding this comment.
Does anyone have these permissions on .com or .org? I assume there was a reason we did it this way, but I don't remember :x
There was a problem hiding this comment.
Looks like we had a comment:
# Hack around get_objects_for_user not supporting global perms
Looks like get_objects_for_user isn't used anymore, so probably safe.
There was a problem hiding this comment.
Only the build user has that permission set
In [10]: User.objects.filter(user_permissions__isnull=False).distinct()
Out[10]: <QuerySet [<User: build>]>That's in .org, in .com we have 0 users.
We use the is_superuser check in .com, while we check for has_perm in .org. These checks are only for the api user, and has_perm always returns true for superusers. I have checked and our api users are superusers, so all good.
stsewd
force-pushed
the
querysets-check-superuser
branch
from
e7f229f to
65b6d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the is_superuser check in .com,
while we check for has_perm in .org.
These checks are only for the api user,
and has_perm always returns true for superusers.
I have checked and our api users are superusers,
so all good.
Also, user is always required.